Martian Intuition - of Mogrify, Ruby Tempfile & Dynamic Class Definitions Comments

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by Fred Liang

2011-10-09T03:28:09Z

Why you didn't pass params like this Tempfile.new ['filenane', '.stuffix']

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by Michael MacDonald

2011-01-06T04:43:23Z

When I upgraded to Ruby 1.9.2 I got the following error with this patch:

can't convert nil into Integer

To solve this, I used the same trick as the paperclip folks used:

sprintf('%s%d-%d%s', File::basename(basename, ext), $$, n.to_i, ext)

Notice the addition of n.to_i.

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by Shyam Khadka

2010-10-05T06:38:17Z

Looks great!! But in my case, ext = File::extname(basename) doesn't return anything.

So that I am not able to get extension of temp file using file_field of rails. Any suggestions are highly welcomed!!

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by silverdr

2009-08-08T18:21:00Z

Steve - thanks. Simple solution to my problem.

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by Matt

2008-04-28T16:57:28Z

Do you know if the newest version fixes this? == 1.2.2 / 2007-06-01

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by Steve

2007-07-15T17:48:23Z

I had the same exact problem and extended your idea a little. This modification to make_tmpname allows you to create temp files with whatever extension you like (but if you don't specify an extension, it works like normal):

Module MiniMagick
  class ImgTempFile < Tempfile
    def make_tmpname(basename, n)
      # force tempfile to use basename's extension if provided
      ext = File::extname(basename)
      # force hyphens instead of periods in name
      sprintf('%s%d-%d%s', File::basename(basename, ext), $$, n, ext)
    end
  end # class
end # module

Also, I chose to subclass Tempfile rather than overwrite, which required a small alteration to mini_magick.rb:

          tmp = ImgTempFile.new("minimagic")

Finally, here's a short test that shows it's working (put it in any convenient test file that gets run on related stuff):

  def test_image_temp_file
    tmp = MiniMagick::ImgTempFile.new('test')
    assert_match %r{^test}, File::basename(tmp.path)
    tmp = MiniMagick::ImgTempFile.new('test.jpg')
    assert_match %r{^test}, File::basename(tmp.path)
    assert_match %r{\.jpg$}, File::basename(tmp.path)
  end

Comment on 'of Mogrify, Ruby Tempfile & Dynamic Class Definitions' by mzpn

2007-07-15T17:48:23Z

fun